ASoC: SOF: Remove redundant code in irq function on cnl - #56
Merged
Conversation
plbossart
reviewed
Jul 24, 2018
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
Looks good, but the commit message makes no sense.
"Now the second query is reserved sine it is used
immediately after this query"
Not sure what "reserved" means here.
-> did you mean "the first query is removed, we keep the second query since the results are immediately used in a test"?
Author
|
yes, you got my idea |
Member
|
can you please edit the commit message then? Thanks! |
Member
|
Can we please close this one, the commit message needs to be edited before merge. Thanks. |
The HIPCTDR is queried two times in this function. The first query is removed, we keep the second query since the result is immediately used in a test Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
Author
|
@plbossart update my commit message. Thanks for review! |
plbossart
approved these changes
Jul 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HIPCTDR is queried two times in this function.
The first query is removed, we keep the second query
since the result is immediately used in a test
Signed-off-by: Rander Wang rander.wang@linux.intel.com